Fix #474, Add timecb global mutex #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integration Candidate COMBINED 2020-04-29 and 2020-05-06
The mutex to protect the timer callback (timecb) resource table was missing.
jphickey
added
the
CCB:Ready
|
Does this mean everywhere it was requesting the lock/unlock it was really just a no-op and returning error (since mut == null)? |
|
Yes, but only for the "TimeCB" object table -- which typically is only used once at startup (when still single threaded) and maybe once in SCH. So low impact as far as usage goes. Surprised that this was not noticed before.... |
skliper
approved these changes
May 20, 2020
|
CCB 20200520 - APPROVED |
skliper
added
CCB-20200520
and removed
CCB:Ready
astrogeco
added
the
CCB:Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Adds the mutex to protect the timer callback (timecb) resource table.
Fixes #474
Testing performed
Build and confirm all unit tests pass, CFE runs normally.
Expected behavior changes
Timer callback (timcb) resource types are mutex protected.
System(s) tested on
Ubuntu 20.04
RTEMS 4.11 on pc686 via QEMU
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.