Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration Candidate 2020-05-13 #477

Merged
merged 3 commits into from
May 22, 2020
Merged

Integration Candidate 2020-05-13 #477

merged 3 commits into from
May 22, 2020

Conversation

astrogeco
Copy link
Contributor

@astrogeco astrogeco commented May 19, 2020

Describe the contribution
Fix #235

Testing performed
Bundle CI - https://travis-ci.com/github/nasa/cFS/builds/167639047

Expected behavior changes
PR #448 - OS_QueueCreate() will return an error code if the depth parameter is larger than the configured OS_MAX_QUEUE_DEPTH.

System(s) tested on
Ubuntu:Bionic

Additional context
See PRs for detailed test and change information
Part of nasa/cFS#87

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

jphickey and others added 2 commits May 7, 2020 15:25
The OS_QueueCreate() function will now sanity check the depth
parameter against the configured OS_MAX_QUEUE_DEPTH value.  If
it is too large, an error will be returned.  This is a hard limit
and independent of the "permissive" mode.

The OS_MAX_QUEUE_DEPTH should be configured to the largest value
that an application may reasonably request.
Fix #235, add check against OS_MAX_QUEUE_DEPTH
@astrogeco astrogeco marked this pull request as draft May 19, 2020 22:08
@astrogeco astrogeco marked this pull request as ready for review May 22, 2020 14:54
@astrogeco astrogeco merged commit 3597aaf into master May 22, 2020
@skliper skliper added this to the 5.1.0 milestone Jun 1, 2020
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
Fix nasa#408, Remove device driver references in code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

osconfig.h OS_QUEUE_MAX_DEPTH unused
3 participants