Fix #550, add function groups to ut assert #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up and Refactor the internal list storage structures to support having multiple list heads/groups. Define a separate list/group for setup, normal test, and teardown. The existing UtTest_Add() routine maps to the normal test group. Added a UtTest_AddSetup() and UtTest_AddTeardown() routine that maps to the setup and teardown group, respectively. The existing UtTest_Run() routine then merges the groups and executes the full suite of tests. This allows separate, dynamic registration of test setup and teardown routines which are executed before and after the normal test routine, which can create and delete any global/common test prerequisites.
jphickey
added
the
CCB:Ready
|
CCB 2020-08-05 APPROVED |
astrogeco
added
CCB:Approved
|
@jphicky Could this have caused UT_AddSubTests to no longer execute? I haven't dug in yet, but my subtests are no longer running. |
|
I just checked the latest bundle and ran the SB unit tests (which are the only ones I know that use the Note that "subtest" is nothing more than a wrapper around the normal I did notice that it is doing a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Clean up and Refactor the internal list storage structures to support having multiple list heads/groups. Define a separate list/group for setup, normal test, and teardown.
The existing UtTest_Add() routine maps to the normal test group. Added a UtTest_AddSetup() and UtTest_AddTeardown() routine that maps to the setup and teardown group, respectively.
The existing UtTest_Run() routine then merges the groups and executes the full suite of tests.
This allows separate, dynamic registration of test setup and teardown routines which are executed before and after the normal test routine, which can create and delete any global/common test prerequisites.
Fixes #550
Testing performed
Build and run all unit tests
Update a unit test to additionally register separate setup and teardown functions and confirm that these are always run first and last, respectively.
Expected behavior changes
Test programs may now register global setup and teardown routines.
System(s) tested on
Ubuntu 20.04
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.