Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #377, Add "OSAL Select" functional tests #683

Merged

Conversation

zanzaben
Copy link
Contributor

Describe the contribution
Fixes #377
Added new functional tests for the the select and select multiple functions.

Testing performed
Ran the new tests.

Expected behavior changes
None

System(s) tested on
Ubuntu 20.04

Contributor Info - All information REQUIRED for consideration of pull request
Alex Campbell GSFC

Copy link
Contributor

@skliper skliper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the client sockets get closed?

src/tests/select-test/select-test.c Outdated Show resolved Hide resolved
src/tests/select-test/select-test.c Outdated Show resolved Hide resolved
src/tests/select-test/select-test.c Outdated Show resolved Hide resolved
src/tests/select-test/select-test.c Outdated Show resolved Hide resolved
src/tests/select-test/select-test.c Outdated Show resolved Hide resolved
src/tests/select-test/select-test.c Outdated Show resolved Hide resolved
src/tests/select-test/select-test.c Show resolved Hide resolved
src/tests/select-test/select-test.c Outdated Show resolved Hide resolved
@zanzaben zanzaben force-pushed the fix377_Select_Functional_Tests branch from d0f3120 to b18e9d3 Compare December 15, 2020 15:19
@zanzaben zanzaben added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Dec 15, 2020
@astrogeco astrogeco changed the title Fix377 select functional tests Fix #377, "OSAL Select" functional tests Dec 16, 2020
@astrogeco astrogeco added CCB-20201216 and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Dec 16, 2020
@astrogeco astrogeco changed the title Fix #377, "OSAL Select" functional tests Fix #377, Add "OSAL Select" functional tests Dec 16, 2020
@astrogeco
Copy link
Contributor

CCB 2020-12-16 APPROVED

  • Run clang-format for consistency
  • Teardown closes the sockets and are used for all the tests

@zanzaben zanzaben force-pushed the fix377_Select_Functional_Tests branch from d15206b to 1b85700 Compare December 16, 2020 17:32
@skliper
Copy link
Contributor

skliper commented Dec 16, 2020

@zanzaben - could you add a more descriptive commit message on the last two commits? The current text isn't sufficient to describe the change. Let me know if suggestions would help.

@zanzaben zanzaben force-pushed the fix377_Select_Functional_Tests branch from 1b85700 to 87b8915 Compare December 16, 2020 18:36
@zanzaben zanzaben force-pushed the fix377_Select_Functional_Tests branch from 87b8915 to d5727f9 Compare December 16, 2020 21:01
@astrogeco astrogeco changed the base branch from main to integration-candidate December 18, 2020 14:28
@astrogeco astrogeco merged commit 3705934 into nasa:integration-candidate Dec 18, 2020
astrogeco added a commit to nasa/cFS that referenced this pull request Dec 18, 2020
@skliper skliper added this to the 6.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OSAL Select APIs missing functional test
3 participants