Fix #708, chmod error handling #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphickey
force-pushed
the
fix-708-chmod-err-handling
branch
from
a7fc6e1
to
cca5821
Compare
Better error translations in the OS_FileChmod_Impl() function. Also corrects a file handle leak. This makes it return OS_ERR_NOT_IMPLEMENTED when run on a file system that does not have permissions, which in turn causes the unit test to be skipped rather than fail.
jphickey
force-pushed
the
fix-708-chmod-err-handling
branch
from
cca5821
to
fcfba48
Compare
jphickey
added
the
CCB:Ready
skliper
approved these changes
Dec 29, 2020
zanzaben
approved these changes
Dec 29, 2020
astrogeco
added
CCB-20210106
and removed
CCB:Ready
|
CCB 2021-01-06 APPROVED
|
jphickey
added a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Add support for a TGTx_PROCESSOR_ID directive, which allows one to set the default value returned by CFE_PSP_GetProcessorId() function, rather than assuming the index value from CMake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Implement better error translations in the OS_FileChmod_Impl() function.
Also corrects a file handle leak.
This makes it return OS_ERR_NOT_IMPLEMENTED when run on a file system that does not have permissions, which in turn causes the unit test to be skipped rather than fail.
Fixes #708
Testing performed
Build and run all unit tests
Expected behavior changes
The chmod test is now skipped on VxWorks rather than failing.
System(s) tested on
Ubuntu 20.04 (native)
VxWorks 6.9 (mcp750)
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.