Fix #755, resolve subtasks not ending on time #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanzaben
added
the
CCB:Ready
|
@astrogeco hotfix candidate? should fix hang in IC. |
skliper
approved these changes
Jan 12, 2021
|
CCB 2021-01-13 APPROVED Test was getting stuck in a semaphore due to sockets. Another error was a conflict with duplicate names. All tests have unique names now. @jphickey will connect to discuss more details Sockets are being closed before deleting the task. |
astrogeco
added
CCB:2021-01-13
and removed
CCB:Ready
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Integration Candidate: 2020-06-17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #755
Removed the second semaphore that was trying to make sure the subtasks finish closing and instead just forcibly close them from the main task.
Testing performed
Ran the select test 300 times on my computer with no fails.
Expected behavior changes
Test should not fail or hang
System(s) tested on
Ubuntu 20.04
Contributor Info - All information REQUIRED for consideration of pull request
Alex Campbell GSFC