Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work #384, #640, #672, Minor fixes to osal config guide #812

Merged
merged 3 commits into from
May 18, 2021
Merged

Work #384, #640, #672, Minor fixes to osal config guide #812

merged 3 commits into from
May 18, 2021

Conversation

Kronos3
Copy link
Contributor

@Kronos3 Kronos3 commented Feb 14, 2021 •
edited by astrogeco
Loading

Describe the contribution
I noticed a few things missing from the documentation.
There were also duplicate entries in one of the tables

Partially addresses #384, #640, #672

Testing performed
(none)

Expected behavior changes
No impact to behavior

System(s) tested on
Gentoo Linux - amd64

Contributor Info
Andrei Tumbar (NASA JPL) andrei.tumbar@jpl.nasa.gov / andreitumbar@gmail.com

@skliper
Copy link
Contributor

skliper commented Feb 16, 2021

This is partially related to #672 and #384

@skliper skliper added the CCB:PendingCLA External contribution pending CLA confirmation label Mar 5, 2021
@astrogeco astrogeco added docs and removed CCB:PendingCLA External contribution pending CLA confirmation labels May 4, 2021
@astrogeco
Copy link
Contributor

Thanks for the contribution Andrei!

@astrogeco astrogeco requested a review from jphickey May 4, 2021 00:09
jphickey
jphickey approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually touches a couple spots that my previous PR also did, so we'll have to merge. Looks good though.

@astrogeco
Copy link
Contributor

Hi again @Kronos3, if you haven't done so already please, download, sign, and email the appropriate Contributor License agreement below to GSFC-SoftwareRelease@mail.nasa.gov and cfs-program@lists.nasa.gov.

Corporate Contributor License agreement
Individual Contributor License agreement

THANKS!

@astrogeco astrogeco added the CCB:PendingCLA External contribution pending CLA confirmation label May 11, 2021
@Kronos3
Copy link
Contributor Author

Kronos3 commented May 14, 2021

Hi @astrogeco, I submitted the license agreement, should I expect a reply (submitted 3 days ago)?

@astrogeco astrogeco changed the title Minor documentation enhancements Fix #640, Minor documentation enhancements May 16, 2021
@astrogeco astrogeco changed the title Fix #640, Minor documentation enhancements Work #640, Minor documentation enhancements May 16, 2021
@astrogeco astrogeco changed the base branch from main to integration-candidate May 16, 2021 16:24
@astrogeco astrogeco added IC:2021-05-18 and removed CCB:PendingCLA External contribution pending CLA confirmation labels May 16, 2021
@astrogeco
Copy link
Contributor

Thanks Andrei!

Had some kinks in the process internally but we’re all squared away. I also saw you made some merges to the PR to square away conflicts, thank you for that. I’ll take it from here. If you want more details on how our merges typically work, check out our contributing guide.

Thanks for the contribution!

@astrogeco astrogeco changed the title Work #640, Minor documentation enhancements Work #384, #672, Minor documentation enhancements May 17, 2021
@astrogeco astrogeco mentioned this pull request May 17, 2021
Open
@astrogeco astrogeco changed the title Work #384, #672, Minor documentation enhancements Work #384, #640, #672, Minor documentation enhancements May 17, 2021
@astrogeco astrogeco changed the title Work #384, #640, #672, Minor documentation enhancements Work #384, #640, #672, Minor fixes to osal config guide May 18, 2021
@astrogeco astrogeco merged commit 788d3fc into nasa:integration-candidate May 18, 2021
@astrogeco astrogeco added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label May 18, 2021
@astrogeco astrogeco mentioned this pull request May 19, 2021
Merged
astrogeco added a commit to nasa/cFS that referenced this pull request May 19, 2021
@astrogeco
IC:2021-05-18, add cfe and osal PRs
1536820 
nasa/cFE#1482, Resolve sequence count auto-increment rollover bug

nasa/osal#985, rename hooks to handlers
nasa/osal#1000, propagate status code in OS_rmdir
nasa/osal#1001, rework "unit-tests" to use macros
nasa/osal#1003, remove extra newlines in utassert logs
nasa/osal#990, Add test for object id inline functions
nasa/osal#998, fixed invalid inputs for OS_mkdir
nasa/osal#812, Improves config guide documentation
@astrogeco astrogeco mentioned this pull request May 19, 2021
Merged
astrogeco added a commit to nasa/cFS that referenced this pull request May 19, 2021
@astrogeco
IC:2021-05-18, cfe and osal
da34c28 
Combines:

nasa/cFE#1508, cFE v6.8.0-rc1+dev580
nasa/osal#1006, osal v5.1.0-rc1+dev452

Includes:

nasa/cFE#1482, Resolve sequence count auto-increment rollover bug
nasa/cFE#1491, Correctly format code block section terminator
nasa/cFE#1530, Fix typos in developer guide

nasa/osal#985, rename hooks to handlers
nasa/osal#1000, propagate status code in OS_rmdir
nasa/osal#1001, rework "unit-tests" to use macros
nasa/osal#1003, remove extra newlines in utassert logs
nasa/osal#990, Add test for object id inline functions
nasa/osal#998, fixed invalid inputs for OS_mkdir
nasa/osal#812, Improves config guide documentation
nasa/osal#987, Show CodeQL Preview
@skliper skliper linked an issue May 19, 2021 that may be closed by this pull request
Update OSAL Configuration Guide, build instructions, directory references, etc #384
Closed
@skliper skliper mentioned this pull request May 19, 2021
Closed
astrogeco added a commit to nasa/cFS that referenced this pull request May 19, 2021
@astrogeco @skliper
@jphickey @ArielSAdamsNASA @zanzaben @tniessen @jbohren-hbr @Kronos3
IC:2021-05-18, cfe and osal
cbd1fe2 
Combines:

nasa/cFE#1508, cFE v6.8.0-rc1+dev580
nasa/osal#1006, osal v5.1.0-rc1+dev452

Includes:

nasa/cFE#1482, Resolve sequence count auto-increment rollover bug
nasa/cFE#1491, Correctly format code block section terminator
nasa/cFE#1530, Fix typos in developer guide

nasa/osal#985, rename hooks to handlers
nasa/osal#1000, propagate status code in OS_rmdir
nasa/osal#1001, rework "unit-tests" to use macros
nasa/osal#1003, remove extra newlines in utassert logs
nasa/osal#990, Add test for object id inline functions
nasa/osal#998, fixed invalid inputs for OS_mkdir
nasa/osal#812, Improves config guide documentation
nasa/osal#987, Show CodeQL Preview

Co-Authored-By: Jake Hageman <skliper@users.noreply.github.com>
Co-Authored-By: Joseph Hickey <joseph.p.hickey@nasa.gov>
Co-Authored-By: Ariel Adams <ArielSAdamsNASA@users.noreply.github.com>
Co-Authored-By: Alex Campbell <zanzaben@users.noreply.github.com>
Co-Authored-By: Tobias Nießen <tniessen@users.noreply.github.com>
Co-Authored-By: Jonathan Bohren <jbohren-hbr@users.noreply.github.com>
Co-Authored-By: Andrei Tumbar <Kronos3@users.noreply.github.com>
@astrogeco astrogeco removed the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label May 26, 2021
pepepr08 pushed a commit to pepepr08/osal that referenced this pull request Jun 9, 2021
@Kronos3 @pepepr08
Work nasa#384, nasa#640, nasa#672, Minor fixes to osal config guide (n…
1f24dd6 
…asa#812)

* Minor documentation enhancements
@skliper skliper added this to the 6.0.0 milestone Sep 24, 2021
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
@pepepr08
Fix nasa#812 Add Perf API functional tests
c5e7165 
and add Perf Trigger and Perf Start commands to functional tests workflow
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
@pepepr08
Fix nasa#812 Start Perf Data before running tests
6887fbf
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
@astrogeco
Merge pull request #1800 from pepepr08/fix812-perf-ft
9da565a 
Fix nasa#812, Add Perf API functional tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jphickey jphickey jphickey approved these changes

Assignees
No one assigned
Labels
CCB:FastTrack community docs squash
Projects
None yet
Milestone
Caelum
Development

Successfully merging this pull request may close these issues.

Update OSAL Configuration Guide, build instructions, directory references, etc
4 participants
@Kronos3 @skliper @astrogeco @jphickey