Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #752, Utilize UTASSERT_CASETYPE_NA to report OS_ERR_NOT_IMPLEMENTED #816

Closed

Conversation

zanzaben
Copy link
Contributor

@zanzaben zanzaben commented Feb 16, 2021

Describe the contribution
(would have fixed #752)
use UTASSERT_CASETYPE_NA instead of UtPrintf to report cases when not implemented

Testing performed
Build and run unit test

Expected behavior changes
No impact to behavior

System(s) tested on
Ubuntu 20.04

Contributor Info - All information REQUIRED for consideration of pull request
Alex Campbell GSFC

@zanzaben zanzaben added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Feb 16, 2021
Copy link
Contributor

@skliper skliper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also needs update:

/*
** dump the symbol table with a 32768 byte limit
*/
UtPrintf("Dumping symbol table with a limit of 32768 bytes\n");
status = OS_SymbolTableDump("/ram/SymbolTable32k.dat", 32768);
UtAssert_True(status == OS_SUCCESS || status == OS_ERR_NOT_IMPLEMENTED, "status after 32k OS_SymbolTableDump = %d",
(int)status);
/*
** dump the symbol table with a 128k byte limit
*/
UtPrintf("Dumping symbol table with a limit of 131072 bytes\n");
status = OS_SymbolTableDump("/ram/SymbolTable128k.dat", 131072);
UtAssert_True(status == OS_SUCCESS || status == OS_ERR_NOT_IMPLEMENTED, "status after 128k OS_SymbolTableDump = %d",
(int)status);
/*
** dump the symbol table with a 512k byte limit
*/
UtPrintf("Dumping symbol table with a limit of 524288 bytes\n");
status = OS_SymbolTableDump("/ram/SymbolTable512k.dat", 524288);
UtAssert_True(status == OS_SUCCESS || status == OS_ERR_NOT_IMPLEMENTED, "status after 512k OS_SymbolTableDump = %d",
(int)status);

@zanzaben zanzaben force-pushed the fix752_uniform_not_implemented_tests branch from 9004e4c to ebef88b Compare February 17, 2021 15:10
@zanzaben zanzaben force-pushed the fix752_uniform_not_implemented_tests branch from ebef88b to f92d6f4 Compare February 17, 2021 15:13
@astrogeco
Copy link
Contributor

CCB 2021-02-17 Make a macro to replace multiple instances of "copy-pasted" code

@astrogeco astrogeco removed the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Feb 17, 2021
@zanzaben zanzaben closed this Feb 23, 2021
@zanzaben zanzaben deleted the fix752_uniform_not_implemented_tests branch February 23, 2021 17:18
@zanzaben zanzaben restored the fix752_uniform_not_implemented_tests branch March 9, 2021 15:11
@skliper
Copy link
Contributor

skliper commented Mar 9, 2021

This was rejected in favor of making a macro and using it in all these cases (could be done as part of #787 or independent)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test case reporting of not-implemented functionality not uniform
3 participants