Fix #197, test teardown cleanup #949
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cleans up all OSAL resources as best as possible, ideally leaving the system in a state where OS_API_Init() may be invoked again.
Invoke OS_API_Teardown to reset state for next test
|
Pushed initially as draft since this depends on #948. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Invokes OS_API_Teardown as a test teardown function for all unit tests. This returns the global state objects to their initial state and therefore allows the test to be re-run/repeated without rebooting. It also ensures that any resources allocated by the test are removed before the test finishes.
Testing performed
Build and run all unit tests, confirm passing
Expected behavior changes
Test resources are cleaned up to the extent possible, and set back to initial state. Tests can be repeated if desired.
System(s) tested on
Ubuntu 20.04
MCP750 Vxworks 6.9
Additional context
Depends on #948
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.