Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #969, socket accept using incorrect record #971

Merged
merged 2 commits into from
Apr 28, 2021
Merged

Fix #969, socket accept using incorrect record #971

merged 2 commits into from
Apr 28, 2021

Commits on Apr 27, 2021

  1. Fix nasa#969, socket accept using incorrect record 

    The OS_SocketAccept call was using the incorrect token, using
the server/acceptor socket when it should have used the connection
socket.

The bug overwrote data in the acceptor socket, but it would only cause
an issue when the user attempted to use the server socket to accept
a second connection, but the tests only performed a single connection.

This also improves the network-api-test to do multiple connections,
re-using the same acceptor socket between them.
    @jphickey
    jphickey committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    479c021 View commit details
    Browse the repository at this point in the history

  2. Fix nasa#969, Use UtAssert tool API for count pattern 

    The stream test was sending an 8-bit count pattern to validate
the connection, but was not using the provided API to do so.

This provides the exact same test but uses the provided API
from UtAssert to implement it, rather than duplicating the logic.

Notably, this also confirms that the tool functions work as
expected, since there were no other OSAL tests using this API.
    @jphickey
    jphickey committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    05a20f1 View commit details
    Browse the repository at this point in the history