Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add command that uses an input parameter #211

Closed
jphickey opened this issue Nov 1, 2023 · 0 comments · Fixed by #212
Closed

Add command that uses an input parameter #211

jphickey opened this issue Nov 1, 2023 · 0 comments · Fixed by #212
Assignees
@jphickey
Labels
enhancement New feature or request

Comments

@jphickey
Copy link
Contributor

jphickey commented Nov 1, 2023

Is your feature request related to a problem? Please describe.
In the sample app, there is no example of a command that uses parameters.

Aside from noop/reset there is currently just one command and it displays the information from a table. This is fine for a table example, but it would be helpful to see an example for a command that has input parameters.

Describe the solution you'd like
Add a command that accepts a string and a numeric input and displays them.

Additional context
The intent is to demonstrate how this should be implemented and serve as a basis for users to hook in real functionality.

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Nov 1, 2023
@jphickey jphickey added the enhancement New feature or request label Nov 1, 2023
@jphickey jphickey mentioned this issue Nov 1, 2023
Merged
dzbaker added a commit that referenced this issue Nov 13, 2023
@dzbaker
Merge pull request #212 from jphickey:fix-210-211
091a962 
Fix #210, Fix #211, bring sample_app fully into compliance
@dzbaker dzbaker mentioned this issue Nov 13, 2023
Merged
2 tasks
jphickey added a commit to jphickey/sample_app that referenced this issue Apr 15, 2024
@jphickey
Fix nasa#211, add DisplayValue command
b5aea12 
The display value command shows an example of how to pass in and use a
parameter with a command.  3 types are illustrated; a signed and
unsigned int, and a string.
jphickey added a commit to jphickey/sample_app that referenced this issue Apr 15, 2024
@jphickey
fixup! Fix nasa#211, add DisplayValue command
1692670
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #210, Fix #211, bring sample_app fully into compliance jphickey/sample_app
1 participant
@jphickey