-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sample_table.c -- relocate? #70
Labels
question
Further information is requested
Comments
CDKnightNASA
added
question
Further information is requested
CCB:Ready
Pull request is ready for discussion at the Configuration Control Board (CCB)
labels
Jun 2, 2020
Would like CCB decision on this, thx. |
Yes - sample_table is the wrong place, it should be in a separate dir, not in Recommend |
CCB-2020-06-03: APPROVED concept |
CDKnightNASA
added a commit
to CDKnightNASA/sample_app
that referenced
this issue
Jun 3, 2020
astrogeco
removed
the
CCB:Ready
Pull request is ready for discussion at the Configuration Control Board (CCB)
label
Jun 5, 2020
astrogeco
pushed a commit
that referenced
this issue
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Tables are a component of applications that are expected to be customized by the user. The cFS build process supports this customization (for example, by creating
sample_defs/tables/cpu1_sample_table.c
). Currentlysample_table.c
is infsw/src
but everything else infsw/src
is not expected to be customized by the user.I consider sample_app to be the "style template" for applications, so this should be clear not just for users of the sample_app but for folks who model their code on sample_app.
Describe the solution you'd like
I would like to see a clearer indication that
sample_table.c
is expected to be customized--whether it be relocated to a different folder (fsw/tables
?) or possibly rename it tosample_table.c.sample
?Requester Info
Christopher.D.Knight@nasa.gov
The text was updated successfully, but these errors were encountered: