tblCRCTool Integration Candidate: 2020-11-24 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sizeof() will keep this tool in sync if the size of the CFE file or table header should ever change. Note this also implicitly restricts this tool to the CFE build environment where these headers are available. As a result this will no longer be buildable as a fully standalone/external tool.
Fix #3, use sizeof() for header sizes.
Set REVISION version number to 99 to indicate development status. Bump baseline to tagged Bootes release candidate.
Integration Candidate 2020-11-24
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Dec 3, 2020
Combines nasa/cFE#1027 nasa/osal#662 nasa/PSP#221 nasa/sample_app#113 nasa/sample_lib#38 nasa/sch_lab#58 nasa/tblCRCTool#25 Co-authored-by: Joseph Hickey <joseph.p.hickey@nasa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #3, use sizeof() for header sizes.
HOTFIX, Set REVISION to 99 and update baseline
Testing performed
See events for "github actions test" at https://github.com/astrogeco/cFS/actions
Expected behavior changes
PR #23 - Use
sizeof()instead of a hard coded value for the table file header size to keep this tool in sync if the size of the cFE file or table header should ever change.System(s) tested on
Ubuntu 18.04
Additional context
Part of nasa/cFS#158
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
@jphickey