Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #179, Light initialization logic refactor + remove multiple returns #180

Merged

Conversation

thnkslprpt
Copy link
Contributor

Checklist

Describe the contribution

Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).
Tested locally with cFS build + test commands - all working fine.

Expected behavior changes

  • if CFE_SB_CreatePipe fails when creating the command pipe, to_lab will not go on try to create the telemetry pipe.
  • if CFE_SB_CreatePipe fails when creating the telemetry pipe, to_lab will not try to add the subscriptions - which makes little sense anyway...
  • also, in neither case will to_lab now report successful initialization if the pipes cannot be created.
  • the delete handler will be installed now in all cases even if one of the early calls to cFE fails - this is the case also in other apps.

System(s) tested on
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS bundle.

Contributor Info
Avi Weiss   @thnkslprpt

@thnkslprpt thnkslprpt force-pushed the fix-179-initialization-logic-improvements branch from cc850eb to e8f3dcf Compare March 23, 2024 11:13
@dzbaker dzbaker added the CCB:Approved Indicates approval by CCB label Sep 26, 2024
dzbaker added a commit to nasa/cFS that referenced this pull request Oct 3, 2024
*Combines:*

cFE equuleus-rc1+dev205
to_lab equuleus-rc1+dev62

**Includes:**

*cFE*
- nasa/cFE#2602
- nasa/cFE#2606

*to_lab*
- nasa/to_lab#171
- nasa/to_lab#180

Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
Co-authored by: Maxime Haselbauer <renn0xtek9@users.noreply.github.com>
Co-authored by: Anh Van <avan989@users.noreply.github.com>
@dzbaker dzbaker merged commit 5dcd109 into nasa:main Oct 3, 2024
11 checks passed
dzbaker added a commit to nasa/cFS that referenced this pull request Oct 3, 2024
*Combines:*

cFE equuleus-rc1+dev205
to_lab equuleus-rc1+dev62

**Includes:**

*cFE*
- nasa/cFE#2602
- nasa/cFE#2606

*to_lab*
- nasa/to_lab#171
- nasa/to_lab#180

Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
Co-authored by: Maxime Haselbauer <renn0xtek9@users.noreply.github.com>
Co-authored by: Anh Van <avan989@users.noreply.github.com>
@thnkslprpt thnkslprpt deleted the fix-179-initialization-logic-improvements branch October 4, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates approval by CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Light initialization logic refactor + remove multiple returns
3 participants