Fix #179, Light initialization logic refactor + remove multiple returns #180
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
TO_LAB_init
refactored to remove multiple returns, and not continue with subsequent steps after a serious failure of a call to cFE during the initializationTesting performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).
Tested locally with cFS build + test commands - all working fine.
Expected behavior changes
CFE_SB_CreatePipe
fails when creating the command pipe, to_lab will not go on try to create the telemetry pipe.CFE_SB_CreatePipe
fails when creating the telemetry pipe, to_lab will not try to add the subscriptions - which makes little sense anyway...System(s) tested on
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS bundle.
Contributor Info
Avi Weiss @thnkslprpt