Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #131, Rename CommandCode variable to Fcncode #171

Merged

Conversation

thnkslprpt
Copy link
Contributor

Checklist

Describe the contribution

Testing performed
Standard cFS bundle tests all passed.
Build/run cFS and test NOOP and other commands with the GroundSystem tool. All working fine.

Expected behavior changes
No impact on behavior.
Improves code clarity and consistency in the lab apps.

System(s) tested on
Intel(R) Celeron(R) N4100 CPU @ 1.10GHz x86_64
Debian GNU/Linux 11 (bullseye)
cFS main branch

Contributor Info
Avi Weiss @thnkslprpt

Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concur -- FcnCode is the preferred name nowadays.

@dzbaker dzbaker added the CCB:Approved Indicates approval by CCB label Sep 26, 2024
dzbaker added a commit to nasa/cFS that referenced this pull request Oct 3, 2024
*Combines:*

cFE equuleus-rc1+dev205
to_lab equuleus-rc1+dev62

**Includes:**

*cFE*
- nasa/cFE#2602
- nasa/cFE#2606

*to_lab*
- nasa/to_lab#171
- nasa/to_lab#180

Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
Co-authored by: Maxime Haselbauer <renn0xtek9@users.noreply.github.com>
Co-authored by: Anh Van <avan989@users.noreply.github.com>
@dzbaker dzbaker merged commit a014daf into nasa:main Oct 3, 2024
11 checks passed
dzbaker added a commit to nasa/cFS that referenced this pull request Oct 3, 2024
*Combines:*

cFE equuleus-rc1+dev205
to_lab equuleus-rc1+dev62

**Includes:**

*cFE*
- nasa/cFE#2602
- nasa/cFE#2606

*to_lab*
- nasa/to_lab#171
- nasa/to_lab#180

Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
Co-authored by: Maxime Haselbauer <renn0xtek9@users.noreply.github.com>
Co-authored by: Anh Van <avan989@users.noreply.github.com>
@thnkslprpt thnkslprpt deleted the fix-131-rename-CommandCode-to-FcnCode branch October 4, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates approval by CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recommend using FcnCode (instead of CommandCode) terminology in the code
3 participants