-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #149, update cmake recipe #150
Conversation
522fac3
to
20b7fb6
Compare
Thanks @skliper - was in too much of a hurry to get some PRs submitted yesterday. |
Prefer target-scope properties over directory scope where applicable
20b7fb6
to
f908518
Compare
@dzbaker This one should be OK now. I found an issue of an errant line I had put in to test something and removed it, now the workflow failure that I see is related to I'd recommend merging all 4 cmake updates into "integration-candidate" and running the workflow there, it should go cleanly. |
*Combines:* PSP v1.6.0-rc4+dev71 ci_lab v2.5.0-rc4+dev43 sample_app v1.3.0-rc4+dev39 sch_lab v2.5.0-rc4+dev49 to_lab v2.5.0-rc4+dev41 **Includes:** *PSP* - nasa/PSP#389 *ci_lab* - nasa/ci_lab#136 *sample_app* - nasa/sample_app#203 *sch_lab* - nasa/sch_lab#136 *to_lab* - nasa/to_lab#150 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
*Combines:* PSP v1.6.0-rc4+dev71 ci_lab v2.5.0-rc4+dev43 sample_app v1.3.0-rc4+dev39 sch_lab v2.5.0-rc4+dev49 to_lab v2.5.0-rc4+dev41 **Includes:** *PSP* - nasa/PSP#389 *ci_lab* - nasa/ci_lab#136 *sample_app* - nasa/sample_app#203 *sch_lab* - nasa/sch_lab#136 *to_lab* - nasa/to_lab#150 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
*Combines:* PSP v1.6.0-rc4+dev71 ci_lab v2.5.0-rc4+dev43 sample_app v1.3.0-rc4+dev39 sch_lab v2.5.0-rc4+dev49 to_lab v2.5.0-rc4+dev41 **Includes:** *PSP* - nasa/PSP#389 *ci_lab* - nasa/ci_lab#136 *sample_app* - nasa/sample_app#203 *sch_lab* - nasa/sch_lab#136 *to_lab* - nasa/to_lab#150 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
Describe the contribution
Prefer target-scope properties over directory scope where applicable
Fixes #149
Testing performed
Build and run, sanity check
Expected behavior changes
No impact
System(s) tested on
Debian
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.