-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #30, Resolve doxygen warning #31
Fix #30, Resolve doxygen warning #31
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually that path is wrong... might be a remnant of the classic build.?
Correct Path is fsw/platform_inc/to_lab_sub_table.h
, relative to wherever the to_lab source resides. In other places I think some documentation uses the cmake-like syntax to indicate the source dir, i.e. ${TO_LAB_SOURCE_DIR}
.
Futhermore, this is a header file that really shouldn't be instantiating a table. Header files aren't supposed to instantiate data, just define it. (isn't this a standards issue?) That should probably be a separate ticket though.
Corrected -- I originally missed the leading fsw/
Yes, standards issue and a new ticket, see #32. Just fix the path in this one. |
@lbleier-GSFC can you fix per @jphickey comment? |
Done |
@lbleier-GSFC can you update the issue name as "Fix #NUMBER," need the "#" for github to link the issue and we've been using commas as a separator. |
@astrogeco Is that better? |
autolink still missing, and preferred commit message: "Fix #30, Resolve doxygen warning" |
Fixed the issue link and updated title, not sure why it wouldn't autolink... did it by hand. |
CCB 2020-04-29 : APPROVED |
Describe the contribution
Fix #30
Resolve doxygen warnings
Testing performed
Steps taken to test the contribution:
make doc
Expected behavior changes
Changes to documentation only; no code impact
Contributor Info - All information REQUIRED for consideration of pull request
Leor Bleier, NASA\GSFC