Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MonteCarloGeneration: Provide more dispersion details when generate_meta_data is active #1574

Closed
ddj116 opened this issue Sep 18, 2023 · 2 comments
Assignees

Comments

@ddj116
Copy link
Contributor

ddj116 commented Sep 18, 2023

Some Ramtares users have requested added capability when monte_carlo.master.generate_meta_data = True, copied from the original GitLab thread:

we are looking to output the dispersion type, min/max, and mean/sigma for all monte carloed variables ... I see that this metadata output just says "random". We are looking for dispersionTypes like Gaussian, and uniform

Currently, the output of variables in the meta data file looks like this:

Screenshot 2023-09-15 at 1 45 19 PM

This might require a refactor of the underlying classes so that this information is available inside collate_meta_data().

Adding suggested implementation details from the original thread:

Add a virtual method to each "variable" type to return a string containing content specific to that type, then in mc_master, call the method on each "variable", appending the returned string to some list ready for output. Probably need to look at the specifics of each class to identify what sort of information gets returned -- e.g. for a normal distribution, do you also need information about applied truncations?

@sharmeye
Copy link
Contributor

We'll put this on our list, but we're not super familiar with the section of code so we'll have to do some digging first.

@ddj116
Copy link
Contributor Author

ddj116 commented Sep 21, 2023

Sorry for the confusion - I've already got an implementation from the needing user, and I'll be putting that together in a PR for y'all to take a look at when I get time (hopefully next week).

@ddj116 ddj116 self-assigned this Sep 21, 2023
ddj116 pushed a commit that referenced this issue Nov 29, 2023
* Add type, dispersion, min_value, max_value and other relevant internal
  members of MonteCarloVariable* classes to the output of
  MonteCarlo_Meta_data_output. Motivation is for users wanting to post-process
  dispersion parameters used during generation of runs
* Protect against invalid memory access when length of values is zero in
  MonteCarloVariableRandomStringSet::generate_assignment(). Add a new
  verif sim warning case to cover these new lines
* Update new verif data for SIM_mc_generation to support these changes

Closes #1574
ddj116 pushed a commit that referenced this issue Nov 30, 2023
* Add type, dispersion, min_value, max_value and other relevant internal
  members of MonteCarloVariable* classes to the output of
  MonteCarlo_Meta_data_output. Motivation is for users wanting to post-process
  dispersion parameters used during generation of runs
* Protect against invalid memory access when length of values is zero in
  MonteCarloVariableRandomStringSet::generate_assignment(). Add a new
  verif sim warning case to cover these new lines
* Update new verif data for SIM_mc_generation to support these changes

Closes #1574
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants