Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

in ICG: Add FileSkipped preprocessor callback to FindTrickICG #1125

Merged
merged 8 commits into from
Apr 20, 2021
Merged

in ICG: Add FileSkipped preprocessor callback to FindTrickICG #1125

merged 8 commits into from
Apr 20, 2021

Conversation

spfennell
Copy link
Contributor

See issue #608

#608 add implementation of FileSkipped callback to FindTrickICG to ad…
5908fca 
…d include chains for headers that have already been preprocessed
@spfennell
Copy link
Contributor Author

I'll merge this after I write a test for it

@spfennell
Copy link
Contributor Author

Tests fail as expected on test-only branch 608-add-test-ci-should-fail.

dbankieris
dbankieris approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@dbankieris dbankieris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the test sim!

@spfennell spfennell merged commit 9589c10 into master Apr 20, 2021
@spfennell
Copy link
Contributor Author

closes #608

@spfennell spfennell deleted the 608-findtrickicg-header-skipped branch February 28, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbankieris dbankieris dbankieris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spfennell @dbankieris