Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In honor of "Change Spaces To Tabs Day", circa 2009 #1770

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

excaliburtb
Copy link
Contributor

@sharmeye you know what this is in reference to, right?

@ddj116
Copy link
Contributor

ddj116 commented Sep 3, 2024

Upvoting for visibility. 👍 Very nice, great success!

@alexlin0
Copy link
Contributor

alexlin0 commented Sep 3, 2024

You have to take into account when a space is enclosed in single quotes, ' ', and not change that one.

@excaliburtb
Copy link
Contributor Author

apologies. the holiday description isn't that specific

@alexlin0
Copy link
Contributor

alexlin0 commented Sep 3, 2024

I propose a new description, "Change Spaces to Tabs Except When Enclosed By Single Quotes Day"

@sharmeye
Copy link
Contributor

sharmeye commented Sep 5, 2024

We'll accept the pull if you replicate the entirety of Trick code with #ifdefs that check if the date is 9/3/2009 and, if so, replace spaces with tabs. To be clear, this needs to be an entirely separate code base, none of this putting #ifdefs in existing code.

Also it must all be retyped by hand, using a dvorak keyboard, with full support for the Shavian alphabet.

Also all unit test must likewise be re-coded by hand as described above to determine if the tabs are correctly implemented.

You must also retype all the makefiles.

As all other pull requests must do, you are obligated to satisfy (with proof) that this release would be dolphin safe. That is, and has always been, our #1 priority.

@excaliburtb
Copy link
Contributor Author

it is dolphin safe (confirmed yesterday) but we'll have to add a peanut and lactose allergy warning to TrickView and ControlPanel

@keithvetter
Copy link
Contributor

Tabs use gluten to hide all that space in a single character. For dolphins with sensitivity to gluten, we may need to tack on to the peanut and lactose warnings.

@ddj116
Copy link
Contributor

ddj116 commented Sep 5, 2024

As the only person here that has written tests robust enough to handle the content in this PR, I hereby decree that no PR shall be merged without an attached image of something photoshopped or AI'd for the amusement of the Trick core team.

borat_trickops_tests

@lquiocho
Copy link

lquiocho commented Sep 6, 2024

I'll wait until the "Change StudlyCaps Variable Names to camelCase Day" to celebrate! Everyone already knows how I feel about tabs ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants