Fixed one warning message at shutdown after checkpoint load and kept the current multicast group after checkpoint load. #1784
+9
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tructor; Made sure that the MulticastGroup is not initialized before initializing it in VariableServerListenThread.cpp;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an external app such as the sim control panel is configured as following in the input file, the corresponding destructor gets called at the shutdown. In turn, the MM will try to clean the memory for the vars related to the external app even those vars were already taken care of due to the shutdown. Thus there was a warning message.
simControlPanel = trick.SimControlPanel()trick.add_external_application(simControlPanel)However, if having
trick.sim_control_panel_set_enabled(True)in the input file, there was no warning message.Adding a check before deleting vars would eliminate the warning.
Made sure that the multicast group is not initialized before initializing it in VariableServerListenThread.cpp. Without the check, trick-sniffer wouldn't find the sim anymore after loading a checkpoint as the multicast group got initialized again even it was already initialized.