fix: TPROCTE_HOME Being Used In Place Of TPRO_HOME #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compiling Trick with the --with-tpro option for use of a real-time clock, the TPROCTE_HOME variable was being assigned the contents of the withval variable instead of being assigned to the TPRO_HOME variable. The TPROCTE_HOME variable was never used and the TPRO_HOME variable will always be an empty string. Thus, the configuration file will always check for only /h/tpro.h instead of <user-provided-path-to-tpro>/h/tpro.h
|
Thanks for the fix! |
alexlin0
added a commit
that referenced
this pull request
Jun 11, 2019
Needed to make some more fixes to work with modern tsync driver code.
alexlin0
added a commit
that referenced
this pull request
Jun 11, 2019
Need to exclude the tsync directory from Trick operations.
alexlin0
added a commit
that referenced
this pull request
Jun 11, 2019
Changed the Tsync routing from using the old TPro API to the new Tsync API.
alexlin0
added a commit
that referenced
this pull request
Jun 12, 2019
I put the include for tsync.h in the wrong place.
alexlin0
added a commit
that referenced
this pull request
Jun 14, 2019
Tell ICG not to process board handle variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Hi Trick team,
My name is Esteban Duran. I am a former intern of Frank Delgado's at JSC. I now work as a flight software engineer at Firefly Aerospace. The software team and I found this easy to miss discrepancy when enabling real-time clock support in Trick. Thanks for making such a great framework!
Bug
We are trying to enable the use of a real-time clock for Trick and have encountered an issue
Per the documentation, adding the --with-tpro="path/to/driver" when executing the configure script should enable TPRO CTE support. What we found was that the configure file would completely ignore the path provided and simply print out:
configure: error: could not find /h/tpro.hIt looks like in the autoconf/configure.ac on line 63, there are still references to the TPROCTE_HOME variable and it is being used interchangeably with TPRO_HOME. The same is being done in the trick/configure file on line 7079 where the TPROCTE_HOME variable is being set to the withval variable contents but the TPRO_HOME variable is being used to check for the tpro.h file.
The TPROCTE_HOME variable was never used and the TPRO_HOME variable will always be an empty string. Thus, the configuration file will always check for only /h/tpro.h instead of /h/tpro.h.
Fix
Change all references of the TPROCTE_HOME variable in the configure file to TPRO_HOME.