fix: type variable for Logger

the type variable of the logger should be the custom levels type since a recent change in pino types (pinojs/pino#1858) fixes pinojs#313
naseemkullah · Dec 15, 2023 · d272228 · d272228
1 parent 44c61b7
commit d272228
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/index.d.ts b/index.d.ts
@@ -12,13 +12,13 @@ import { IncomingMessage, ServerResponse } from 'http';
 import pino from 'pino';
 import { err, req, res, SerializedError, SerializedRequest, SerializedResponse } from 'pino-std-serializers';
 
-declare function PinoHttp<IM = IncomingMessage, SR = ServerResponse, Opts = Options<IM, SR>>(opts?: Opts, stream?: pino.DestinationStream): HttpLogger<IM, SR, Opts>;
+declare function PinoHttp<IM = IncomingMessage, SR = ServerResponse, CustomLevels extends string = never>(opts?: Options<IM, SR>, stream?: pino.DestinationStream): HttpLogger<IM, SR, CustomLevels>;
 
 declare function PinoHttp<IM = IncomingMessage, SR = ServerResponse>(stream?: pino.DestinationStream): HttpLogger<IM, SR>;
 
-export interface HttpLogger<IM = IncomingMessage, SR = ServerResponse, Opts = Options<IM, SR>> {
+export interface HttpLogger<IM = IncomingMessage, SR = ServerResponse, CustomLevels extends string = never> {
     (req: IM, res: SR, next?: () => void): void;
-    logger: pino.Logger<Opts>;
+    logger: pino.Logger<CustomLevels>;
 }
 export type ReqId = number | string | object;
 

diff --git a/index.test-d.ts b/index.test-d.ts
@@ -208,7 +208,7 @@ const httpServerListener: RequestListener = (request, response) => {
 
 // custom levels added in the options should be available
 // on the logger returned by pino-http
-pinoHttp({
+pinoHttp<IncomingMessage, ServerResponse, 'bark'>({
     customLevels: {
         bark: 25,
     }