[Enhancement] replaced repeated code with the new requestAPI function

naseif · Sep 1, 2021 · 8098f82 · 8098f82
1 parent a931beb
commit 8098f82
Showing 1 changed file with 4 additions and 13 deletions.
diff --git a/commands/fun/jokes.js b/commands/fun/jokes.js
@@ -1,26 +1,17 @@
 const { SlashCommandBuilder } = require("@discordjs/builders");
-const fetch = require("node-fetch");
+const { requestAPI } = require("../../modules/requestAPI");
 
 module.exports = {
   data: new SlashCommandBuilder()
     .setName("joke")
     .setDescription("gets a random joke!"),
   async execute(interaction, client) {
     await interaction.deferReply();
-    async function getJoke() {
-      try {
-        const requestInsult = await fetch(
-          "https://v2.jokeapi.dev/joke/Miscellaneous,Dark,Pun,Spooky,Christmas"
-        );
-        const responseToJson = await requestInsult.json();
-        return responseToJson;
-      } catch (err) {
-        throw err;
-      }
-    }
 
     try {
-      const joke = await getJoke();
+      const joke = await requestAPI(
+        "https://v2.jokeapi.dev/joke/Miscellaneous,Dark,Pun,Spooky,Christmas"
+      );
 
       const embed = {
         color: "#9dcc37",