Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skeleton code structure for Glue L2 construct #1

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Skeleton code structure for Glue L2 construct #1

merged 2 commits into from
Aug 11, 2023

Conversation

mjanardhan
Copy link
Collaborator

REPLACE THIS TEXT BLOCK

Describe the reason for this change, what the solution is, and any
important design decisions you made.

Remember to follow the CONTRIBUTING GUIDE and DESIGN GUIDELINES for any
code you submit.

Closes #.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

natalie-white-aws
natalie-white-aws requested changes Aug 11, 2023
View reviewed changes
Copy link
Owner

@natalie-white-aws natalie-white-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create trigger and job sub-directories to separate classes; add hyphens to file names for readability.

packages/@aws-cdk/aws-glue-alpha/lib/conditionaltrigger.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-glue-alpha/lib/flexjob.ts Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flex-job.ts

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a sub-folder "jobs" to hold all of the Job related classes.

packages/@aws-cdk/aws-glue-alpha/lib/notifyeventtrigger.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-glue-alpha/lib/ondemandtrigger.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-glue-alpha/lib/pythonshelljob.ts Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python-shell-job.ts

packages/@aws-cdk/aws-glue-alpha/lib/rayjob.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-glue-alpha/lib/scheduledtrigger.ts Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scheduled-trigger.ts

packages/@aws-cdk/aws-glue-alpha/lib/sparketljob.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-glue-alpha/lib/streamingjob.ts Outdated Show resolved Hide resolved
natalie-white-aws
natalie-white-aws approved these changes Aug 11, 2023
View reviewed changes
Copy link
Owner

@natalie-white-aws natalie-white-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@mjanardhan mjanardhan merged commit 26265a7 into main Aug 11, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natalie-white-aws natalie-white-aws natalie-white-aws approved these changes

Assignees

@natalie-white-aws natalie-white-aws

Labels
beginning-contributor p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjanardhan @natalie-white-aws