This repository has been archived by the owner on Oct 18, 2022. It is now read-only.
Deploy build artifacts to GCS #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcdenu4
reviewed
Jan 11, 2021
.github/workflows/build-electron.yml
Outdated
| @@ -20,7 +20,7 @@ jobs: | |||
| uses: actions/setup-node@v1 | |||
| with: | |||
| node-version: ${{ matrix.node-version }} | |||
|
|
|||
dcdenu4
reviewed
Jan 11, 2021
Comment on lines
+64
to
+69
| echo "PKG_VERSION=$(jq -r .version package.json)" >> $GITHUB_ENV | ||
| echo "GIT_REV=$(git rev-parse --short HEAD)" >> $GITHUB_ENV | ||
| echo "BUCKET=$([ github.actor == 'natcap' ] \ | ||
| && echo 'gs://releases.naturalcapitalproject.org/invest-workbench/' \ | ||
| || echo 'gs://natcap-dev-build-artifacts/invest-workbench/${{ github.actor }}' \ | ||
| )" >> $GITHUB_ENV |
There was a problem hiding this comment.
Is this the same as export PKG_VERSION=$(jq -r .version package.json)?
There was a problem hiding this comment.
There was a problem hiding this comment.
@dcdenu4 more/less the same I guess. I think I was following some GHA docs...let me see...https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-commands-for-github-actions#setting-an-environment-variable
dcdenu4
suggested changes
Jan 11, 2021
|
Thanks, @dcdenu4 , all yours. |
dcdenu4
approved these changes
Jan 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an Actions step for deploying the electron-builder products (Windows exe installer & Mac DMG) to GCS buckets. Builds on natcap's fork deploy to our releases bucket with an
invest-workbenchprefix. Builds on other forks deploy to natcap-dev-build-artifacts bucket.Note to self: "undraft" this PR after #72 & #73 are merged into
main.