Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conf.py to fix Read the Docs build #1640

Merged

Conversation

emilyanndavis
Copy link
Member

@emilyanndavis emilyanndavis commented Oct 8, 2024

Description

Fixes #1639 by removing a call to get_html_theme_path(), which has been deprecated and is no longer needed, per this message from the RTD build logs:

WARNING: Calling get_html_theme_path is deprecated. If you are calling it to define html_theme_path, you are safe to remove that code.

Checklist

  • [ ] Updated HISTORY.rst and link to any relevant issue (if these changes are user-facing)
  • [ ] Updated the user's guide (if needed)
  • [ ] Tested the Workbench UI (if relevant)

@emilyanndavis emilyanndavis marked this pull request as ready for review October 8, 2024 20:19
Copy link
Member

@phargogh phargogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for hunting this down @emilyanndavis !

@phargogh phargogh merged commit 33bf031 into natcap:main Oct 8, 2024
29 checks passed
@emilyanndavis emilyanndavis deleted the 1639-read-the-docs-build-config-updates branch October 8, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read the Docs builds failing, probably related to rollout of addons
2 participants