Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure compatibility with numpy 2.0 #396

Closed
phargogh opened this issue Jun 18, 2024 · 0 comments · Fixed by #397
Closed

Ensure compatibility with numpy 2.0 #396

phargogh opened this issue Jun 18, 2024 · 0 comments · Fixed by #397
Assignees
@phargogh
Labels
bug Something isn't working in progress Working on it!

Comments

@phargogh
Copy link
Member

Numpy 2.0 was just released, and when I install the latest version (numpy=2.0.0) into an environment and run python -m pytest tests, I'm getting a few failures on my mac:

FAILED tests/test_geoprocessing.py::TestGeoprocessing::test_raster_map_nodata - TypeError: can_cast() does not support Python ints, floats, and complex because the result used to depend on the value.
FAILED tests/test_geoprocessing.py::TestGeoprocessing::test_raster_map_nodata_and_dtype - TypeError: can_cast() does not support Python ints, floats, and complex because the result used to depend on the value.
FAILED tests/test_geoprocessing.py::TestGeoprocessing::test_raster_map_nodata_propagates - TypeError: can_cast() does not support Python ints, floats, and complex because the result used to depend on the value.
FAILED tests/test_geoprocessing.py::TestGeoprocessing::test_reclassify_raster_reclass_max_nodata - TypeError: in method 'Band_SetNoDataValue', argument 2 of type 'double'

Since this is a major api change, maybe we should expand our test matrix to test against numpy 2.0 if we aren't already?
@phargogh phargogh added the bug Something isn't working label Jun 18, 2024
@phargogh phargogh self-assigned this Jun 18, 2024
@phargogh phargogh added the in progress Working on it! label Jun 18, 2024
phargogh added a commit to phargogh/pygeoprocessing that referenced this issue Jun 18, 2024
@phargogh
Adding the numpy array import macro to cython.
5328892 
Builds were failing without this line.
RE:natcap#396
phargogh added a commit to phargogh/pygeoprocessing that referenced this issue Jun 18, 2024
@phargogh
Avoiding a numpy 2.0 api change.
65ea65e 
Numpy 2.0 changed the behavior of numpy.can_cast(): can_cast() was
looking at the type of the int, not the value, I guess.  Updating to use
numpy.result_type definitely uses the scalar value.

RE:natcap#396
phargogh added a commit to phargogh/pygeoprocessing that referenced this issue Jun 18, 2024
@phargogh
Further reworking type checking.
15eae09 
This approach is better - numpy has a function for checking the minimum
dtype needed for a scalar value, so we can use that to see if the type
can cast correctly. RE:natcap#396
phargogh added a commit to phargogh/pygeoprocessing that referenced this issue Jun 18, 2024
@phargogh
Handling numpy values explicitly as nodata values.
b2d52eb 
GDAL only wants python ints/floats, not numpy ints/floats. RE:natcap#396
phargogh added a commit to phargogh/pygeoprocessing that referenced this issue Jun 18, 2024
@phargogh
Noting change in history. RE:natcap#396
bc7b808
@phargogh phargogh mentioned this issue Jun 18, 2024
Merged
phargogh added a commit to phargogh/pygeoprocessing that referenced this issue Jun 18, 2024
@phargogh
Adding verbose python builds for version debugging. RE:natcap#396
5d1f571
phargogh added a commit to phargogh/pygeoprocessing that referenced this issue Jun 19, 2024
@phargogh
Building wheels in a conda-managed environment against conda-managed …
bf60102 
…ABIs for testing. RE:natcap#396
phargogh added a commit to phargogh/pygeoprocessing that referenced this issue Jun 19, 2024
@phargogh
Adding new buildtime deps to build/test. RE:natcap#396
110e044
phargogh added a commit to phargogh/pygeoprocessing that referenced this issue Jun 20, 2024
@phargogh
Restoring isolated builds, restricting numpy runtime.
5fadc14 
RE:natcap#396
phargogh added a commit to phargogh/pygeoprocessing that referenced this issue Jun 20, 2024
@phargogh
Avoiding deprecated numpy APIs. RE:natcap#396
764a6ce
phargogh added a commit to phargogh/pygeoprocessing that referenced this issue Jun 24, 2024
@phargogh
Adding a comment about numpy version cap. RE:natcap#396
cf711f0
phargogh added a commit to phargogh/pygeoprocessing that referenced this issue Jun 24, 2024
@phargogh
Reformatting args block comment. RE:natcap#396
3880b8f
phargogh added a commit to phargogh/pygeoprocessing that referenced this issue Jun 27, 2024
@phargogh
Removing numpy cap for testing. RE:natcap#396
16bdd12
phargogh added a commit to phargogh/pygeoprocessing that referenced this issue Jun 27, 2024
@phargogh
Building against oldest-supported-numpy for python3.8, numpy2 for all…
7fcc940 
… others. RE:natcap#396
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phargogh phargogh

Labels
bug Something isn't working in progress Working on it!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Minor updates for numpy 2.0 compatibility phargogh/pygeoprocessing
1 participant
@phargogh