update to cython 3 #390
update to cython 3 #390
Conversation
| @@ -8,8 +8,7 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| os: [windows-latest, macos-latest] | |||
| python-version: [3.7, 3.8, 3.9, "3.10", "3.11", "3.12"] | |||
| python-arch: [x64] | |||
There was a problem hiding this comment.
python-arch isn't needed here, and it caused an issue with the new ARM64 mac runners.
There was a problem hiding this comment.
I bet this is a holdover from when we were still doing x86 builds. Makes sense to remove!
| @@ -8,8 +8,7 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| os: [windows-latest, macos-latest] | |||
| python-version: [3.7, 3.8, 3.9, "3.10", "3.11", "3.12"] | |||
There was a problem hiding this comment.
python 3.7 is end-of-life, we already removed it from the test workflow. And setup-python couldn't find an ARM64 python 3.7 distribution.
| @@ -8,8 +8,7 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| os: [windows-latest, macos-latest] | |||
| python-version: [3.7, 3.8, 3.9, "3.10", "3.11", "3.12"] | |||
| python-arch: [x64] | |||
There was a problem hiding this comment.
I bet this is a holdover from when we were still doing x86 builds. Makes sense to remove!
| @@ -10,6 +10,7 @@ Unreleased Changes | |||
| called with an invalid resampling algorithm. We now fall back to the | |||
| underlying GDAL functions' error messages. | |||
| https://github.com/natcap/pygeoprocessing/issues/387 | |||
| * Updated to Cython 3. | |||
There was a problem hiding this comment.
If we are removing testing/wheel-building support for python 3.7, should that also be noted here in HISTORY and also removed from the setup.py trove classifiers?
Update to Cython 3. Also fixes the github actions workflow for the new mac runners.