Skip to content

Commit

Permalink
Merge pull request #79 from phargogh/task/78-test-against-python-3.10
Browse files Browse the repository at this point in the history
Test taskgraph against Python 3.10
  • Loading branch information
dcdenu4 authored Oct 6, 2021
2 parents a1c2b4d + d419e00 commit 8357e4d
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 5 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/pythonapp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: [3.6, 3.7, 3.8, 3.9]
python-version: [3.6, 3.7, 3.8, 3.9, "3.10"]
os: [ubuntu-latest, windows-latest, macos-latest]

steps:
Expand Down Expand Up @@ -40,4 +40,4 @@ jobs:
- name: Run tests
run: |
tox
tox
2 changes: 2 additions & 0 deletions HISTORY.rst
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ TaskGraph Release History

Unreleased Changes
------------------
* Testing against python 3.10 in github actions and officially noting support
for 3.10 in ``setup.py``.
* Testing against python 3.9 in github actions and noting support in
``setup.py``.
* Fixed an issue where exceptions raised during execution where the task
Expand Down
1 change: 1 addition & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,5 +39,6 @@
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
'Programming Language :: Python :: 3.9',
'Programming Language :: Python :: 3.10',
'License :: OSI Approved :: BSD License'
])
4 changes: 2 additions & 2 deletions taskgraph/Task.py
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ def _task_executor(self):
if self._terminated:
LOGGER.debug(
"taskgraph is terminated, ending %s",
threading.currentThread())
threading.current_thread())
break
task = None
try:
Expand Down Expand Up @@ -449,7 +449,7 @@ def _task_executor(self):
LOGGER.warning('worker pool was already closed')
LOGGER.debug(
"no tasks are pending and taskgraph closed, normally "
"terminating executor %s." % threading.currentThread())
"terminating executor %s." % threading.current_thread())
break
else:
# there's still the possibility for work to be added or
Expand Down
3 changes: 2 additions & 1 deletion tox.ini
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[tox]
envlist = {py36,py37,py38,py39}-{base,psutil}
envlist = {py36,py37,py38,py39,py310}-{base,psutil}

[gh-actions]
# Allows us to use tox configuration to manage our tests, but still run on
Expand All @@ -10,6 +10,7 @@ python =
3.7: py37
3.8: py38
3.9: py39
3.10: py310

[testenv]
commands =
Expand Down

0 comments on commit 8357e4d

Please sign in to comment.