Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating version fetching to no longer use pkg_resources #101

Conversation

phargogh
Copy link
Member

@phargogh phargogh commented Nov 4, 2023

Using importlib.metadata or importlib_metadata depending on the python version to get version metadata.

Fixes #100

Copy link
Contributor

@davemfish davemfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @phargogh , this begs the question, should we still support python < 3.8? We're no longer testing against it, though pyproject.toml allows >= 3.6. And Python 3.6 & 3.7 have reached end-of-life. Thoughts?

Also, this question can definitely be the topic of a different issue/PR and we can call this one good as-is.

@phargogh
Copy link
Member Author

phargogh commented Nov 6, 2023

Thanks @davemfish ! I was wondering about that as well, and I think it'd be better to push that to another issue (#102) for consideration. Syntactically, I believe python 3.6 and 3.7 should still work, but the question of whether we should be supporting these versions is different. I left things alone because of the syntactic angle rather than the maintenance angle.

@davemfish
Copy link
Contributor

Thanks @davemfish ! I was wondering about that as well, and I think it'd be better to push that to another issue (#102) for consideration. Syntactically, I believe python 3.6 and 3.7 should still work, but the question of whether we should be supporting these versions is different. I left things alone because of the syntactic angle rather than the maintenance angle.

Okay great!

@davemfish davemfish merged commit 1f574f9 into natcap:main Nov 6, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkg_resources has been deprecated for metadata access
2 participants