fixes #31 change default logging level for precalculated to INFO #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @davemfish, I added you as a reviewer since you filed the issue! Let me know if you need any other changes or whatnot. |
richpsharp
changed the title
|
Hi @emlys, do you mind taking a look at one more hopefully simple PR? I'd originally put this to Dave since he requested it but I just realized he's out for another week. Seems a long time to wait for a single line PR+history. |
phargogh
previously approved these changes
Aug 25, 2020
phargogh
approved these changes
Aug 25, 2020
|
🚀 |
|
@richpsharp I see you just re-requested a review from me post-merge ... did I miss something on the PR? I can revert the merge if needed! |
@phargogh, I didn't intentionally do that! Thanks for the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the level of the "not precalculated" logging message from a WARNING to INFO.
Closes #31