custom file and dir permission (#164)

[counten]

No description provided.

[jedisct1]

Any hope to see that PR merged?

[djarbz]

Please merge this!

[counten]

allow user to custom file permission , use default if not configured。 I think this is better for users @natefinch

[jedisct1]

Yes the current behavior is not great.

[fissssssh]

I think using the same permission (0755) as the parent folder could also be feasible.

[fissssssh]

When working with sidecar to collect logs in Kubernetes, this issue becomes quite visible. @jedisct1

[djarbz]

I think using the same permission (0755) as the parent folder could also be feasible.

0644 would be more appropriate for files, we don't need to be able to execute log files.

[fissssssh]

I think using the same permission (0755) as the parent folder could also be feasible.

0644 would be more appropriate for files, we don't need to be able to execute log files.

Yes, changing the file permission to 0644 is sufficient and there is no need to customize the permission further.

#186

[djarbz]

I think using the same permission (0755) as the parent folder could also be feasible.

0644 would be more appropriate for files, we don't need to be able to execute log files.

Yes, changing the file permission to 0644 is sufficient and there is no need to customize the permission further.

#186

I would disagree, having the ability to have restrictive or open permissions on log files is very important in a security sense.
I would prefer this PR over yours.

[counten]

I think using the same permission (0755) as the parent folder could also be feasible.

0644 would be more appropriate for files, we don't need to be able to execute log files.

Yes, changing the file permission to 0644 is sufficient and there is no need to customize the permission further.
#186

I would disagree, having the ability to have restrictive or open permissions on log files is very important in a security sense. I would prefer this PR over yours.

Strict file permissions meet security requirements. Hope to be merged.

[mohamedtaher567]

Is there any hope for this to be merged? Or even reviewed by the owners. So that it could eventually be merged.

[bnpfeife]

+1

I would also like this merged. I think that a library forcing permissions should be a "last resort" option. I totally understand why gpg and ssh do it, but it makes little to no sense for logs. The authors of this library don't have context for which the logs are being used. Having a strict default is fine as long as it is configurable (as it is with this PR).

[zwh8800]

please merge this!

[rohan-rayaraddi]

@natefinch please merge this