Skip to content

Commit

Permalink
Setting the u ABI flag based on sys.maxunicode is incorrect on recent
Browse files Browse the repository at this point in the history
Pythons with PEP 393 Flexible String Representation (so >= 3.3).
Granted, on these Pythons, the SOABI config var should always be set,
but the manual SOABI code path should still try to do the right thing.
  • Loading branch information
natefoo committed Oct 13, 2015
1 parent 62e265e commit a55fa5a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pip/pep425tags.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def get_abi_tag():
if not soabi and impl in ('cp', 'pp'):
d = 'd' if get_config_var('Py_DEBUG') else ''
m = 'm' if get_config_var('WITH_PYMALLOC') else ''
u = 'u' if sys.maxunicode == 0x10ffff else ''
u = 'u' if get_config_var('Py_UNICODE_SIZE') == 4 else ''
abi = '%s%s%s%s%s' % (impl, get_impl_ver(), d, m, u)
elif soabi and soabi.startswith('cpython-'):
abi = 'cp' + soabi.split('-')[1]
Expand Down

0 comments on commit a55fa5a

Please sign in to comment.