Skip to content

Commit

Permalink
Merge pull request #101 from inquam/dev
Browse files Browse the repository at this point in the history
Only evaluate 'needs' constraints of an option if that option is actually used.
  • Loading branch information
Nate Good authored Jul 10, 2019
2 parents ba1ba17 + 06b2d52 commit 0bfb6e3
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/Commando/Command.php
Original file line number Diff line number Diff line change
Expand Up @@ -525,10 +525,11 @@ public function parse()
}
}

// See if our options have what they require
// See if our options have what they require.
// But only do so if the option is actually used
foreach ($this->options as $option) {
$needs = $option->hasNeeds($this->options);
if ($needs !== true) {
if ($needs !== true && array_key_exists($option->getName(), $keyvals)) {
throw new \InvalidArgumentException(
'Option "' . $option->getName() . '" does not have required option(s): ' . implode(', ', $needs)
);
Expand Down

0 comments on commit 0bfb6e3

Please sign in to comment.