-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
$mimeType parameter in body() method sets the expects as well as sends mime type. #119
Comments
Agree it should be documented. In order to make it non breaking for now,
|
That would be good. Personally I think it should just set the mime type of the content you're passing to body(), there are other functions that set the expected return mime type, plus there's also the smart parsing from the response's content-type header. |
As pointed out in Issue #119, this may produce unexpected results. The behavior of this parameter will change in the next minor release. See r0.3.0 branch.
As pointed out in Issue #119, setting expects here may produce unexpected results.
Agree that this could cause unexpected behavior, will change this behavior in the next MINOR version update, 0.3.0 (see r0.3.0 branch). I have updated the docs for now on master. |
This should be fixed so that it only sets the mime type of what is being passed in body, aka, the mime type of the data being sent.
At the very least it should be documented.
The text was updated successfully, but these errors were encountered: