Support configure the app with generic host #363
Conversation
| /// <param name="cancellationToken">A cancellation token</param> | ||
| /// <returns>A task whose result is the exit code of the application</returns> | ||
| public static async Task<int> RunCommandLineApplicationAsync<TApp>( | ||
| this IHostBuilder hostBuilder, string[] args, CancellationToken cancellationToken = default) | ||
| this IHostBuilder hostBuilder, string[] args, Action<CommandLineApplication> configure = null, CancellationToken cancellationToken = default) |
There was a problem hiding this comment.
This probably needs a separate overload so that this isn’t a breaking change.
|
Any objection pls? |
| public CommandLineService(ILogger<CommandLineService<T>> logger, CommandLineState state, | ||
| IServiceProvider serviceProvider) | ||
| IServiceProvider serviceProvider, Action<CommandLineApplication> configure) |
There was a problem hiding this comment.
| IServiceProvider serviceProvider, Action<CommandLineApplication> configure) | |
| IServiceProvider serviceProvider, Action<CommandLineApplication<T>> configure) |
There was a problem hiding this comment.
The problem is the _application is CommandLineApplication but not CommandLineApplication<T>
There was a problem hiding this comment.
Is there a reason we cannot update _application to the generic type?
There was a problem hiding this comment.
It looks very strange to me.
_application = new CommandLineApplication<T>(state.Console, state.WorkingDirectory)
I thought the _application is a generic one but Visual Studio tells me it is not.
There was a problem hiding this comment.
Never mind. I forgot the variable declaration.
| public static async Task<int> RunCommandLineApplicationAsync<TApp>( | ||
| this IHostBuilder hostBuilder, | ||
| string[] args, | ||
| Action<CommandLineApplication> configure, |
There was a problem hiding this comment.
| Action<CommandLineApplication> configure, | |
| Action<CommandLineApplication<TApp>> configure, |
If we make this use the generic parameter, then users can also access the Model and ModelFactory properties.
This PR should fix #309
and fix #358