Ep 2124 updated search #4
Conversation
| @@ -1,11 +1,14 @@ | |||
| import React, { useContext, useState } from 'react'; | |||
| import { Auth0Context } from 'auth/auth0'; | |||
| import { remove } from 'lodash'; | |||
| import classNames from 'classnames'; | |||
There was a problem hiding this comment.
don't think logo should be in org-switcher, either rename the component in something more generic (eg header) or extract if from here
There was a problem hiding this comment.
Will rename it to <Header/>
| })} | ||
| /> | ||
| </button> | ||
| <SidebarClose |
There was a problem hiding this comment.
SidebarToggleButton? cause if opens/closes sidebar
There was a problem hiding this comment.
Will rename it to <SidebarToggle/>
| } | ||
| } | ||
|
|
||
| .ng-ep-kicker { |
There was a problem hiding this comment.
ng-ep-kicker is not in this component, please move it where the element is used
| </SidebarPanel> | ||
| </div> | ||
| <Sidebar> | ||
| <SidebarLayoutSearch selected={!!selected} /> |
There was a problem hiding this comment.
can we just have Sidebar here? and not use children in the sidebar component? don't see why we need this abstraction
There was a problem hiding this comment.
I wanted the <Sidebar /> to be solely responsible for it's layout and the toggle functionality, not for the content inside it. In this way we could put anything inside the sidebar on different pages if that's needed in the future.
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
# [1.17.0](v1.16.3...v1.17.0) (2021-01-28) ### Bug Fixes * **admin:** default value for empty references [EP-3661] ([#435](#435)) ([d55763e](d55763e)) * **admin:** react-hook-form setValue update [EP-3673] ([6a8a3de](6a8a3de)) * **admin:** widgets empty value [EP-3658] ([98169fb](98169fb)) * **earth-admin:** prefix environment variables with ADMIN namespace ([677ee5d](677ee5d)) * **earth-map:** prefix environment variables with MAP namespace ([8cfcbbc](8cfcbbc)) * **map:** Fix Bug caused by cancel collection [IOPLAT-4165] ([00a5376](00a5376)) * **map:** Fix latest collection refresh [IOPLAT-4170] ([c3ba3f0](c3ba3f0)) * **map:** Refresh widgets list on ORG change [IOPLAT-4171] ([3947704](3947704)) * **map:** weglot gatsby integration [EP-3710] ([#445](#445)) ([f708b6e](f708b6e)) * **marapp-admin:** exclude edited layer from included layers dropdown [EP-3676] ([60dd5e8](60dd5e8)) * avoid circular imports in initial-state ([eca3ce4](eca3ce4)) * change build directory for earth-map ([90174d2](90174d2)) * change useForm mode to trigger validation on multiple ways [EP-3675] ([5048ffe](5048ffe)) * location query to include only required fields ([9abd21e](9abd21e)) ### Features * **earth-map:** migrate map module to gatsby ([25354f7](25354f7)) * **map:** Set page background to dark [EP-3281] ([0384a17](0384a17)) * **map:** SWR support on earth page [EP-3524] ([02daba4](02daba4)), closes [#2](#2) [#3](#3) [#4](#4) [#5](#5) [#6](#6) [#7](#7) [#8](#8) [#9](#9) * **map & admin:** russian language support [EP-3723] ([#449](#449)) ([7284f4d](7284f4d))
Update search to also work on the location details page
Checklist
master