Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin): default value for empty references [EP-3661] #435

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

dan-qc
Copy link
Contributor

@dan-qc dan-qc commented Jan 13, 2021

All boxes should be checked before the PR can be accepted. Exceptions can be made, but they need to be argumented and discussed with the reviewer


STORY

Required

  • Added QA classes on main containers and all actionable items like Buttons, Inputs, etc
  • Translated all the user facing text (static & dynamic)
  • Ran Unit Tests and they pass successfuly
  • Added unit tests for the code in earth-shared
  • Ran the linter with yarn lint
  • No TypeScript warnings are introduced
  • I have made corresponding changes to the documentation

Not Needed

  • Drag here



BUGFIX

Required

  • Ran Unit Tests and they pass successfuly
  • Ran the linter with yarn lint
  • No TypeScript warnings are introduced

Not Needed

  • Translated all the user facing text (static & dynamic)
  • I have made corresponding changes to the documentation
  • Drag here



References

Include any links supporting this change such as a:

  • GitHub Issue/PR number addressed or fixed
  • StackOverflow post
  • Support forum thread
  • Related pull requests/issues from other repos

If there are no references, simply delete this section.

By submitting a PR to this repository, you agree to the terms within the Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

@dan-qc dan-qc merged commit d55763e into develop Jan 15, 2021
@dan-qc dan-qc deleted the bug/EP-3661 branch January 15, 2021 07:38
genodeploy pushed a commit that referenced this pull request Jan 28, 2021
# [1.17.0](v1.16.3...v1.17.0) (2021-01-28)

### Bug Fixes

* **admin:** default value for empty references [EP-3661] ([#435](#435)) ([d55763e](d55763e))
* **admin:** react-hook-form setValue update [EP-3673] ([6a8a3de](6a8a3de))
* **admin:** widgets empty value [EP-3658] ([98169fb](98169fb))
* **earth-admin:** prefix environment variables with ADMIN namespace ([677ee5d](677ee5d))
* **earth-map:** prefix environment variables with MAP namespace ([8cfcbbc](8cfcbbc))
* **map:** Fix Bug caused by cancel collection [IOPLAT-4165] ([00a5376](00a5376))
* **map:** Fix latest collection refresh [IOPLAT-4170] ([c3ba3f0](c3ba3f0))
* **map:** Refresh widgets list on ORG change [IOPLAT-4171] ([3947704](3947704))
* **map:** weglot gatsby integration [EP-3710] ([#445](#445)) ([f708b6e](f708b6e))
* **marapp-admin:** exclude edited layer from included layers dropdown [EP-3676] ([60dd5e8](60dd5e8))
* avoid circular imports in initial-state ([eca3ce4](eca3ce4))
* change build directory for earth-map ([90174d2](90174d2))
* change useForm mode to trigger validation on multiple ways [EP-3675] ([5048ffe](5048ffe))
* location query to include only required fields ([9abd21e](9abd21e))

### Features

* **earth-map:** migrate map module to gatsby ([25354f7](25354f7))
* **map:** Set page background to dark [EP-3281] ([0384a17](0384a17))
* **map:** SWR support on earth page [EP-3524] ([02daba4](02daba4)), closes [#2](#2) [#3](#3) [#4](#4) [#5](#5) [#6](#6) [#7](#7) [#8](#8) [#9](#9)
* **map & admin:** russian language support [EP-3723] ([#449](#449)) ([7284f4d](7284f4d))
@dan-qc
Copy link
Contributor Author

dan-qc commented Jan 28, 2021

🎉 This PR is included in version 1.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants