Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(map): preserve language on refresh or app change #345

Merged
merged 2 commits into from
Dec 10, 2020

Conversation

vt90
Copy link
Contributor

@vt90 vt90 commented Dec 9, 2020

All boxes should be checked before the PR can be accepted. Exceptions can be made, but they need to be argumented and discussed with the reviewer


BUGFIX

Required

  • Ran Unit and E2E tests and they pass successfuly
  • Ran the linter with yarn lint
  • No TypeScript warnings are introduced

Not Needed

  • Translated all the static user facing text

STORY

Required

  • Added QA classes on main containers and all actionable items like Buttons, Inputs, etc
  • Translated all the static user facing text
  • Ran Unit and E2E tests and they pass successfuly
  • Added unit tests for the code in earth-shared
  • Ran the linter with yarn lint
  • No TypeScript warnings are introduced

Not Needed

  • Added end to end tests for the main functionality



References

Include any links supporting this change such as a:

  • GitHub Issue/PR number addressed or fixed
  • StackOverflow post
  • Support forum thread
  • Related pull requests/issues from other repos

If there are no references, simply delete this section.

By submitting a PR to this repository, you agree to the terms within the Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Signed-off-by: vt90 <tomsavlad90@gmail.com>
@vt90 vt90 requested a review from ancashoria December 9, 2020 09:42
Signed-off-by: Vlad Tomsa <tomsavlad90@gmail.com>
@vt90 vt90 merged commit 32294bb into develop Dec 10, 2020
@vt90 vt90 deleted the EP-3522-preserve-language branch December 10, 2020 15:20
genodeploy pushed a commit that referenced this pull request Dec 17, 2020
# [1.16.0](v1.15.0...v1.16.0) (2020-12-17)

### Bug Fixes

* **admin:** Fix scrolling while in edit mode [EP-3146] ([1f3be9d](1f3be9d))
* **admin:** fix sidenav search box styling ([#346](#346)) ([1afcb1a](1afcb1a))
* **admin:** handle SSR request for window usage ([1d67f43](1d67f43))
* **admin:** hide collections from places ([#351](#351)) ([613994b](613994b))
* **admin:** loading indicator on user role [EP-3424] ([c9d5dec](c9d5dec))
* **admin:** place edit reset geojson on cancel [EP-3025] ([047af4b](047af4b))
* **auth:** Error message is not displayed when a invalid link from the email is clicked [EP-3443] ([#338](#338)) ([1ed7fe5](1ed7fe5))
* **map:** collection long name overlap [EP-3595] ([a4c906b](a4c906b))
* **map:** preserve language on refresh or app change ([#345](#345)) ([32294bb](32294bb))
* **map:** support for decodeFunction on layers ([b6b98ed](b6b98ed))
* **profile:** split profile fetching and display a visual loading ind… ([#340](#340)) ([9b1d1fa](9b1d1fa))

### Features

* **map:** Clip and export layers [EP-3594] ([7a118c8](7a118c8))
* **map:** download collection metrics [EP-3002] ([#328](#328)) ([7815e82](7815e82))
* **map:** download collection metrics [EP-3002] ([#333](#333)) ([cbc780c](cbc780c))
* **map:** keep map coordinates in url ([#331](#331)) ([2c8cec8](2c8cec8))
* **map:** weglot support [EP-3441] ([#341](#341)) ([5905af3](5905af3))

### Reverts

* Revert "feat(map): download collection metrics [EP-3002] (#328)" (#332) ([a6da184](a6da184)), closes [#328](#328) [#332](#332)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants