Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-default feature build: Feature gate unpack_ffmpeg with download_ffmpeg #56

Conversation

Wumpf
Copy link
Contributor

@Wumpf Wumpf commented Nov 4, 2024

Currently compilation fails when building for non-linux without the download_ffmpeg feature.

This happens because the zip library is (correctly) feature gated to download_ffmpeg. This in turn is used by unpack_ffmpeg which wasn't behind the feature flag!

@Wumpf Wumpf changed the title Feature gate unpack_ffmpeg with download_ffmpeg Fix non-default feature build: Feature gate unpack_ffmpeg with download_ffmpeg Nov 4, 2024
@Wumpf
Copy link
Contributor Author

Wumpf commented Nov 4, 2024

Don't know where else to write that: Awesome project! So much nicer than interfacing with the ffmpeg libraries directly Using it in the Rerun visualization tool now :)

Copy link
Owner

@nathanbabcock nathanbabcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thank you for fixing this.

I'm going to merge this and then create a small follow-up to also add the cargo check step for Mac M1, and perhaps also share some of those common steps across jobs.

Thank you for the kind words, and I'm excited to check out Rerun more deeply. If you run across any pain points or ideas for improvements in the future I would love to hear them!

@nathanbabcock nathanbabcock merged commit 2f63f3a into nathanbabcock:main Nov 4, 2024
3 checks passed
@Wumpf Wumpf deleted the fix-no-download-non-linux-compilation branch November 4, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants