Change python import sorter to isort and fix hassfest errors #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since reorder-python-imports and black conflict in how they format, the pre-commits were always failing. isort is designed to be compatible with black so it should not have these problems in the future. Having changed the formatters, this then reformats all files so that the pre-commits all pass!
|
Not quite working yet. Perhaps a difference between my version of black and the one running on github. Let me fix this up. |
This moves black's version from workflows/tests.yaml to .pre-commit-config.yaml. The version is also upgraded to 24.2 from 23.3.
|
I've also upgraded python to 3.12, black to 24 and flake8 to 7.0.0 and now finally the "Linting / Pre-commit (pull_request)" stage passes. |
danelphick
changed the title
|
With that last update all of the checks including hassfest pass so they've become useful as a gating mechanism again. |
|
Thanks Dan, appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since reorder-python-imports and black conflict in how they format, the pre-commits were always failing. isort is designed to be compatible with black so it should not have these problems in the future.
Having changed the formatters, this then reformats all files so that the formatter pre-commits all pass.
Fixes #359