Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SOH for some inverters, implements #687 #703

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MartB
Copy link

@MartB MartB commented Nov 3, 2024

As discussed in #687, this should roughly implement what we know about the SOH registers.

Tested and working on my H3
Master: 2.01
Manager: 1.80

To Test:

@MartB MartB force-pushed the feat_add_soh branch 2 times, most recently from 92ec347 to e4f02a1 Compare November 3, 2024 21:12
@icornish72
Copy link

Works on my H1-G2.

@canton7
Copy link
Collaborator

canton7 commented Nov 10, 2024

Thanks!

My H1-G1 doesn't appear to have this register. I can't find it in the spec for the pre-1.19 KH either. Do you have any documentation suggesting those should work? Where did you get the address 11104 from?

@canton7
Copy link
Collaborator

canton7 commented Nov 10, 2024

Please run pytest --snapshot-update to update the snapshot tests

@MartB
Copy link
Author

MartB commented Nov 10, 2024

Thanks!

My H1-G1 doesn't appear to have this register. I can't find it in the spec for the pre-1.19 KH either. Do you have any documentation suggesting those should work? Where did you get the address 11104 from?

#686 (reply in thread)
Got the 11104 from here, cant confirm if the H1-G1 or the pre1.19 KH works.

@MartB MartB changed the title Add SOH for all inverters, implements #687 Add SOH for some inverters, implements #687 Nov 10, 2024
@canton7
Copy link
Collaborator

canton7 commented Nov 10, 2024

Thanks! I'll follow up on that thread, try and get to the bottom of if anyone can access it on a H1-G1.

@canton7
Copy link
Collaborator

canton7 commented Nov 12, 2024

Yep, looks like this doesn't work on the H1-G1 sadly.

Unsupported inverters: H1-G1
@MartB
Copy link
Author

MartB commented Nov 14, 2024

@canton7 Thanks for following up! I removed all H1-G1 references.

@canton7
Copy link
Collaborator

canton7 commented Nov 15, 2024

@williamjeccles Mind testing register 37624 on your KH?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants