Fix for second event now showing when range is less than a day and event spans across 2 days #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nathanstitt Hi there! Thank you for your cooperation with us! It's such a tremendous help for us! We love using your component! We'd really appreciate if you could take a look at this quick fix! Thank you in advance! Cheers 🤙🏼 |
|
@nathanstitt is there any chance you could take a look at this? It's just a short one :) |
|
Nifty! I wasn't aware of |
itsnorbertkalacska
deleted the
fix/range-is-less-than-a-day-shows-up-only-as-one-event
branch
|
@nathanstitt Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If for
EventsCollectionthedisplayAllDayflag was set tofalseand the range was less than a day and the event spanned across 2 days (i.e.2019-10-25 23:00:00-2019-10-26 09:00:00) then the event for the second day didn't show. This PR fixes this issue.Types of changes
Related links
https://github.com/rotaready/moment-range#snapto
https://github.com/rotaready/moment-range#by - see the part when
.snapTo()method is usedChangelog
Added
Fixed
EventsCollection'sconstructorwhen it calculates the days for events