Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a couple of situations where streamrip would fail to process the data if the album or the artist included special characters (even one case where the record name had a random trailing empty space).
The format I use is
folder_format = "{albumartist}/{year} - {title}"
, hence an album like2024 - Cool Name
(note trailing space) or2024 - Hot / Cold
(special char) will fail the path creation, since it will try and createC:/2024 - Cool Name /__artwork
(not valid, at least on Windows), or could try and split the path likeC:/2024 - Hot / Cold/__artwork
, and also fail in the process.The PR just adds a simple string validation to prevent any of those invalid characters, as well as trailing spaces.
Example record with special character
Example record with trailing space