allow empty string ("") namespace #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalabelle
requested review from
janlauber,
svengerber,
janfuhrer and
Joel-Haeberli
as code owners
janfuhrer
reviewed
May 8, 2024
There was a problem hiding this comment.
Hi @nalabelle
Thanks for your Contribution!
Sounds reasonable to me, I have tested it locally and it works fine.
|
@nalabelle can you please sign your commit (see github docs)? |
|
Whoops, missed the notification and just saw this. Signed and rebased. |
|
Thanks again, I will create a new release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I never set a namespace, so I'm thinking "" is the default. My
/admin/datastore/{store}/namespacereturns{"data":[{"ns":""}]}. After removing this skip, I can seepbs_snapshot_*stats.Thanks for putting this project up!