Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADDED] multi-subject filtering (and associated transforms) to stream sources #461

Merged
merged 6 commits into from
Aug 12, 2023

Conversation

jnmoyne
Copy link
Contributor

@jnmoyne jnmoyne commented Jun 29, 2023

Adds multi-subject filtering (and associated transforms) to stream sources (see nats-io/nats-server#4276)

@jnmoyne jnmoyne requested a review from ripienaar June 29, 2023 00:02
@ripienaar
Copy link
Collaborator

Seems good, but will block till its in the server.

@jnmoyne jnmoyne force-pushed the jnm/stream_source_multi_subject branch from ecbab1d to a46d40e Compare August 3, 2023 22:23
Copy link
Collaborator

@ripienaar ripienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but some comment about the feature overall

api/streams.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@ripienaar ripienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some questions

api/streams.go Show resolved Hide resolved
Copy link
Collaborator

@ripienaar ripienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jnmoyne jnmoyne merged commit ea73bc4 into main Aug 12, 2023
4 checks passed
@jnmoyne jnmoyne deleted the jnm/stream_source_multi_subject branch August 12, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants