Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generic tags/nsc test enhancements #22

Merged
merged 1 commit into from
Mar 20, 2023
Merged

generic tags/nsc test enhancements #22

merged 1 commit into from
Mar 20, 2023

Conversation

aricart
Copy link
Member

@aricart aricart commented Feb 16, 2023

  • [FIX] made user have GenericFields - for tags, etc
  • [FEAT] added ability to set issuer_account on generic claims
  • [TEST] added ability to set where nsc stores/reads files for cross lib checks
  • [DENO] added a deno.json/lock simplifying std imports
  • [LINT] fixed linter warnings

@aricart aricart temporarily deployed to CI February 16, 2023 16:45 — with GitHub Actions Inactive
@aricart aricart temporarily deployed to CI February 16, 2023 16:45 — with GitHub Actions Inactive
@aricart aricart temporarily deployed to CI February 16, 2023 16:48 — with GitHub Actions Inactive
@aricart aricart temporarily deployed to CI February 16, 2023 16:48 — with GitHub Actions Inactive
@aricart aricart temporarily deployed to CI February 16, 2023 16:50 — with GitHub Actions Inactive
@aricart aricart temporarily deployed to CI February 16, 2023 16:50 — with GitHub Actions Inactive
@aricart aricart temporarily deployed to CI February 16, 2023 19:39 — with GitHub Actions Inactive
@aricart aricart temporarily deployed to CI February 16, 2023 19:39 — with GitHub Actions Inactive
@aricart aricart requested review from Jarema, piotrpio and wallyqs and removed request for Jarema and piotrpio February 16, 2023 19:39
@aricart aricart temporarily deployed to CI March 10, 2023 21:04 — with GitHub Actions Inactive
@aricart aricart temporarily deployed to CI March 10, 2023 21:04 — with GitHub Actions Inactive
@aricart
[FEAT] added AuthenticationResponse
ce47cad 
[FIX] made user have GenericFields - for tags, etc
[FEAT] added ability to set `issuer_account` on generic claims
[TEST] added ability to set where nsc stores/reads files for cross lib checks
[DENO] added a deno.json/lock simplifying std imports
[LINT] fixed linter warnings
@aricart aricart temporarily deployed to CI March 11, 2023 16:41 — with GitHub Actions Inactive
@aricart aricart temporarily deployed to CI March 11, 2023 16:41 — with GitHub Actions Inactive
scottf
scottf approved these changes Mar 20, 2023
View reviewed changes
Copy link

@scottf scottf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart
Copy link
Member Author

aricart commented Mar 20, 2023

[FEAT] added ability to generate auth response jwts
[FIX] made user have GenericFields - for tags, etc
[FEAT] added ability to set issuer_account on generic claims
[TEST] added ability to set where nsc stores/reads files for cross lib checks
[DENO] added a deno.json/lock simplifying std imports
[LINT] fixed linter warnings

@aricart aricart merged commit 41b87a7 into main Mar 20, 2023
@aricart aricart deleted the tags branch March 20, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottf scottf scottf approved these changes

@wallyqs wallyqs Awaiting requested review from wallyqs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aricart @scottf