[ADDED] New websocket connection types #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a LEAF and MQTT websocket connection types. MQTT + WS is not yet supported, but adding it in preparation. The current WEBSOCKET connection type is really for regular clients. Should probably have been something like CLIENT and CLIENT_WS instead of STANDARD and WEBSOCKET, but at the time there was no plan/thinking of adding websocket support to other type of connections. The need for those 2 new connection types is because the admin may want to have a "user" in the config that can connect as a leafnode, either websocket or not, but not use this "user" to connect as a regular client application. It will make more sense with MQTT: one may want an user to connect for MQTT application, either WS or not, but not for a non mqtt client. The new config would look like this: ["MQTT", "MQTT_WS"] Whereas previously, it would have to be: ["MQTT", "WEBSOCKET"] But then this would allow a non MQTT client to connect as long as the application connects to the websocket port (if opened). Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
aricart
approved these changes
Nov 15, 2021
There was a problem hiding this comment.
LGTM - created an issue nats-io/nsc#434 for nsc to be able to set these values.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a LEAF and MQTT websocket connection types. MQTT + WS is
not yet supported, but adding it in preparation.
The current WEBSOCKET connection type is really for regular clients.
Should probably have been something like CLIENT and CLIENT_WS instead
of STANDARD and WEBSOCKET, but at the time there was no plan/thinking
of adding websocket support to other type of connections.
The need for those 2 new connection types is because the admin may
want to have a "user" in the config that can connect as a leafnode,
either websocket or not, but not use this "user" to connect as
a regular client application. It will make more sense with MQTT:
one may want an user to connect for MQTT application, either WS or
not, but not for a non mqtt client. The new config would look like
this:
["MQTT", "MQTT_WS"]
Whereas previously, it would have to be:
["MQTT", "WEBSOCKET"]
But then this would allow a non MQTT client to connect as long as
the application connects to the websocket port (if opened).
Signed-off-by: Ivan Kozlovic ivan@synadia.com