Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADR-44: Update to Partially Implemented #304

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

MauriceVanVeen
Copy link
Member

Update ADR-44 to "Partially Implemented" status.

  • Rename "feature level" to "API level" to be consistent with the implementation
  • Add missing metadata field _nats.created.server.api_level
  • Add section about "When to increment API Level"

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
adr/ADR-44.md Outdated Show resolved Hide resolved
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Copy link
Contributor

@ripienaar ripienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ripienaar ripienaar merged commit 2c9cc9d into main Sep 10, 2024
1 check passed
@ripienaar ripienaar deleted the adr-44/update-to-partially-implemented branch September 10, 2024 17:05
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants